ARROW-4211: [GLib] Add GArrowFixedSizeBinaryDataType#3358
Closed
shiro615 wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-4211: [GLib] Add GArrowFixedSizeBinaryDataType#3358shiro615 wants to merge 3 commits intoapache:masterfrom
shiro615 wants to merge 3 commits intoapache:masterfrom
Conversation
kou
requested changes
Jan 9, 2019
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
Thanks!
Could you check my comments?
Should we add garrow_fixed_size_binary_data_type_get_byte_width() in this pull request? It's OK to me that we work on it in another pull request.
| GARROW_TYPE_DOUBLE, | ||
| GARROW_TYPE_STRING, | ||
| GARROW_TYPE_BINARY, | ||
| GARROW_TYPE_FIXED_SIZE_BINARY, |
Member
There was a problem hiding this comment.
Putting a new enum value into middle of enums breaks a ABI compatibility.
But we don't need to care for now. Because we bump shared library version for each version. We can't do this when we release 1.0.0.
Contributor
Author
There was a problem hiding this comment.
I see. I'll care from now on.
Contributor
Author
Yes. I'll add it in this pull request. |
Member
|
I've implemented |
kou
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.